Skip to content

trezor: restore support for external inputs #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

trezor: restore support for external inputs #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b798ca4
trezor: add Trezor Safe 5 support
matejcik Jul 1, 2024
e114031
build: make sure Trezors are built with gcc 12
matejcik Jul 1, 2024
232aa54
trezor: restore support for external inputs
matejcik Mar 17, 2022
0159365
trezor: add support for pre-signed external inputs
matejcik Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 50 additions & 50 deletions docs/devices/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,56 +10,56 @@ The table below lists what devices and features are supported for each device.
* ``✗`` - supported by the firmware and not implemented in HWI
* ``―`` - not supported by the firmware

+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Feature \\ Device | Ledger Nano X | Ledger Nano S | Trezor One | Trezor Model T | BitBox01 | BitBox02 | KeepKey | Coldcard | Blockstream Jade |
+====================================+===============+===============+==============+================+==========+==========+=========+==========+==================+
| Support Planned | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Implemented | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| xpub retrieval | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Message Signing | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Device Setup | ― | ― | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ― |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Device Wipe | ― | ― | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ― |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Device Recovery | ― | ― | ✓ | ✓ | ― | ✓ | ✓ | ― | ― |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Device Backup | ― | ― | ― | ― | ✓ | ✓ | ― | ✓ | ― |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| P2PKH Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| P2SH-P2WPKH Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| P2WPKH Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| P2SH Multisig Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| P2SH-P2WSH Multisig Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| P2WSH Multisig Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Bare Multisig Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Taproot Inputs | ✓* | ✓* | ✓* | ✓* | ― | ― | ― | ― | ― |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Arbitrary scriptPubKey Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Arbitrary redeemScript Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Arbitrary witnessScript Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Non-wallet inputs | ✓ | ✓ | ✗\ :sup:`1` | ✗\ :sup:`2` | ✓ | ― | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Mixed Segwit and Non-Segwit Inputs | ― | ― | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+
| Display on device screen | ✓ | ✓ | ✓ | ✓ | ― | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+----------------+----------+----------+---------+----------+------------------+

* 1 - Support removed for devices with firmware 1.10.6 and greater.
* 2 - Support removed for devices with firmware 2.4.4 and greater.
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Feature \\ Device | Ledger Nano X | Ledger Nano S | Trezor One | later Trezor models | BitBox01 | BitBox02 | KeepKey | Coldcard | Blockstream Jade |
+====================================+===============+===============+==============+=====================+==========+==========+=========+==========+==================+
| Support Planned | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Implemented | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| xpub retrieval | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Message Signing | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Device Setup | ― | ― | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ― |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Device Wipe | ― | ― | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ― |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Device Recovery | ― | ― | ✓ | ✓ | ― | ✓ | ✓ | ― | ― |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Device Backup | ― | ― | ― | ― | ✓ | ✓ | ― | ✓ | ― |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| P2PKH Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| P2SH-P2WPKH Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| P2WPKH Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| P2SH Multisig Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ― | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| P2SH-P2WSH Multisig Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| P2WSH Multisig Inputs | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Bare Multisig Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Taproot Inputs | ✓* | ✓* | ✓* | ✓* | ― | ― | ― | ― | ― |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Arbitrary scriptPubKey Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Arbitrary redeemScript Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Arbitrary witnessScript Inputs | ✓ | ✓ | ― | ― | ✓ | ― | ― | ― | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Non-wallet inputs | ✓ | ✓ | ✓\ :sup:`1` | ✓\ :sup:`2` | ✓ | ― | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Mixed Segwit and Non-Segwit Inputs | ― | ― | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+
| Display on device screen | ✓ | ✓ | ✓ | ✓ | ― | ✓ | ✓ | ✓ | ✓ |
+------------------------------------+---------------+---------------+--------------+---------------------+----------+----------+---------+----------+------------------+

* 1 - Since firmware 1.11.1, safety checks must be disabled.
* 2 - Since firmware 2.5.1, safety checks must be disabled.

\* There are some caveats. See the `sign_tx` for these devices.

Expand Down
Loading