Skip to content

Conversation

JamieDriver
Copy link

We can now use the main esp-idf toochain to install the appropriate version of the qemu emulator, rather than building it ourselves from source. Mirrors change recently made to Jade repo.

@JamieDriver JamieDriver force-pushed the update_jade_simulator branch from 19a76c5 to 850e186 Compare March 24, 2025 09:59
We can now use the main esp-idf toochain to install the appropriate
version of the qemu emulator, rather than building it ourselves from
source.  Mirrors change recently made to Jade repo.
@JamieDriver JamieDriver force-pushed the update_jade_simulator branch from 850e186 to a5f9672 Compare March 24, 2025 10:09
This was referenced Jul 22, 2025
achow101 added a commit that referenced this pull request Sep 3, 2025
70e14aa ci: move type check and simbuilds to own file (Sjors Provoost)
b2e1405 ci: use Device Test Template (Sjors Provoost)
6b923c8 ci: combine dist and test jobs (Sjors Provoost)
48e5b9a bitbox02: fix path to simulator (Marko Bencun)
1c53f9a support BitBox02 Nova by updating bitbox02 lib to v7.0.0 (Marko Bencun)
e771d31 ci: pin non-device jobs to Python 3.12 (Sjors Provoost)
5f0edff ledger: use NanoX (Sjors Provoost)
a482d15 ci: downgrade Trezor sim builder to Ubuntu 22.04 (Sjors Provoost)
0639d6d ci: downgrade Coinkite sim builder and tests to Ubuntu 22.04 (Sjors Provoost)
260277f ci: downgrade Keepkey sim builder to Ubuntu 22.04 (Sjors Provoost)
536e9cb ci: split device groups (Sjors Provoost)
4aa0b26 Revert "ci: Always run test" (Sjors Provoost)
3d7c3c9 ledger: disable several tests for NanoX (Sjors Provoost)
79bc788 ledger: add missing ledgerd (Sjors Provoost)
103d70d ledger: add missing flask-cors (Sjors Provoost)
598aad2 coldcard: disable test_signtx (Sjors Provoost)
7dc2579 coldcard: use --headless (Sjors Provoost)
451efa6 coldcard: install pysdl2-dll (Sjors Provoost)
ba3c050 coldcard: update multisig patch (Sjors Provoost)
a539f1b coldcard: drop address patch (Sjors Provoost)
514fe63 ci: build bitcoind with Ubuntu 22.04 (Sjors Provoost)
4457bac Set 60 second timeout on proc.communicate (Sjors Provoost)
48d965d ci: abort if simulator fails to start (Sjors Provoost)
784342f ci: abort if bitcoind fails to start (Sjors Provoost)
9c83f52 jade setup_environment: update qemu installation (Jamie C. Driver)
c5f62a0 ci: fix rust emulator build failure (Sjors Provoost)
72bbef2 ci: .github match 'on' from Bitcoin Core (Sjors Provoost)
8215159 build: bump debian to bookworm (Sjors Provoost)
b8d7147 Drop Python 3.8 (Sjors Provoost)
07b3ae7 ci: bump docker/build-push-action to v6 (Sjors Provoost)
6149775 Adjust bitcoind location (Sjors Provoost)

Pull request description:

  - Modernize
    - bump build.Dockerfile to Debian bookworm
    - bump https://github.com/docker/build-push-action from v5 to v6 (probably wasn't the issue)
    - drop Python 3.8: https://devguide.python.org/versions/ (some jobs were failing, though I didn't investigate)
  - glibc compatility
    - downgrade build machines for Ledger, Keepkey and Coldcard simulators to fix their build
    - downgrade build machines for Trezor simulator for glibc compatibility

  - Robustness / CI performance
    - revert #743
    - split device groups (see picture below)
    - abort test if any simulator fails to start
  - bitcoind
    - `src/bitcoind` was moved to `bin/bitcoind` by bitcoin/bitcoin#31161
    - build `bitcoind` with Ubuntu 22.04 for glibc compatibility
    - abort test if bitoind fails to start
  - Coldcard
    - update patches
    - add `pysdl2-dll`
    - use `--headless`
  - Jade
    - include #779
  - Ledger
    - use LedgerX app (except for legacy)
    - update PyQt to 6 for Speculos: LedgerHQ/speculos#565
    - add `flask-cors`
    - add `ledgerd`
  - Trezor
    - add missing rust-src dependency

  The simulator build jobs as well as the simulator test jobs are split in one group per device brand. This means that the failure of one simulator to build will only cancels jobs for that simulator and not the other ones. Previously this was done in #743 using `always()`, but that's a bit overkill.

  <img width="968" height="681" alt="Schermafbeelding 2025-08-29 om 19 09 56" src="https://github.com/user-attachments/assets/b69d8a3b-5f38-481d-90b8-5731fb2c60b6" />

  Issues left for a followup:

  - #799
  - #800

ACKs for top commit:
  achow101:
    ACK 70e14aa

Tree-SHA512: 9e7af775fe4d1b9faa77827055d4ac31c4d619b07277bdb940e8ede7eaf833484e2b33a0bd4751cd8227f44e7991d428edaaeb25a404a16ec1ca93d90a563145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant