-
Notifications
You must be signed in to change notification settings - Fork 225
MuSig2 #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Sjors
wants to merge
7
commits into
bitcoin-core:master
Choose a base branch
from
Sjors:musig2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MuSig2 #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked the latest version of all the independent PRs. Other than displaying an address this should be all you need to use MuSig2. |
This was referenced Aug 1, 2025
Co-Authored-By: Salvatore Ingala <[email protected]>
Taken from LedgerHQ/app-bitcoin-new at 2.4.1 Conflicts: hwilib/devices/ledger.py Rename tx to psbt.
This adds support handling public nonces and partial signatures.
Somehow I thought I already implemented sending, but it seems I didn't. Done now. Tested with key path as well as script path. |
This was referenced Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines:
So the general workflow is:
bitcoin rpc send '[{"bc1p...": 0.000001}]' fee_rate=1 add_to_wallet=false psbt=true
(optionally usekeypath_only=true
)bitcoin rpc setwalletflag external_signer false
and reload the wallet if neededhwi signtx
bitcoin-cli walletprocesspsbt
hwi signtx
bitcoin-cli walletprocesspsbt
(should return a hex)Note that Ledger is a bit finicky (which we should probably work around):
TODO:
displayaddress
support for policy; the nice thing is that we can just pass an index along with the policy, so we can make--policy
mutually exclusive with--path
and--desc