Fix CI (?)

.github/actions/build-bitcoind/action.yml

@@ -23,7 +23,7 @@ runs:
         ccache --zero-stats
         cd test; ./setup_environment.sh --bitcoind; cd ..
         ccache --show-stats --verbose
-        tar -czf bitcoind.tar.gz test/work/bitcoin/build/src/bitcoind
+        tar -czf bitcoind.tar.gz test/work/bitcoin/build/bin/bitcoind
 
     - uses: actions/cache/save@v4
       if: github.event_name != 'pull_request' && steps.ccache-cache.outputs.cache-hit != 'true'

.github/workflows/ci.yml

@@ -1,9 +1,13 @@
 name: CI
 on:
+  # See: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request.
   pull_request:
+  # See: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#push.
   push:
-    branches: ['**']
-    tags-ignore: ['**']
+    branches:
+      - '**'
+    tags-ignore:
+      - '**'
 
 concurrency:
   group: ${{ github.event_name != 'pull_request' && github.run_id || github.ref }}
@@ -91,7 +95,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - uses: docker/build-push-action@v5
+      - uses: docker/build-push-action@v6
         with:
           context: .
           file: contrib/build-wine.Dockerfile
@@ -115,7 +119,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - uses: docker/build-push-action@v5
+      - uses: docker/build-push-action@v6
         with:
           context: .
           file: contrib/build.Dockerfile
@@ -196,21 +200,22 @@ jobs:
 
   bitcoind-builder:
     name: bitcoind builder
-    runs-on: ubuntu-latest
+    # Ubuntu 22.04 ships with glibc 2.35, which is needed to keep binaries
+    # compatible with Debian Bookworm (glibc 2.36) Python containers.
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/build-bitcoind
 
   test-dist:
     name: Python ${{ matrix.python-version }} ${{ matrix.device }} ${{ matrix.script.name }}
     runs-on: ubuntu-latest
-    if: ${{ always() }}
     needs: [ dist-builder, sim-builder, ledger-app-builder, bitcoind-builder ]
 
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12' ]
+        python-version: [ '3.9', '3.10', '3.11', '3.12' ]
         device:
           - 'trezor-1'
           - 'trezor-t'
@@ -274,14 +279,13 @@ jobs:
   test-all:
     name: Python ${{ matrix.python-version }} ${{ matrix.device }} ${{ matrix.interface }}
     runs-on: ubuntu-latest
-    if: ${{ always() }}
     needs: [ sim-builder, ledger-app-builder, bitcoind-builder ]
     timeout-minutes: 45
 
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12' ]
+        python-version: [ '3.9', '3.10', '3.11', '3.12' ]
         device:
           - 'trezor-1'
           - 'trezor-t'

ci/cirrus.Dockerfile

@@ -1,6 +1,6 @@
 # Cache break (modify this line to break cirrus' dockerfile build cache) 1
 
-FROM python:3.8
+FROM python:3.9
 
 ENV DEBIAN_FRONTEND=noninteractive
 RUN apt-get update
@@ -10,7 +10,7 @@ RUN apt-get install -y \
     bsdmainutils \
     build-essential \
     ccache \
-    clang \    
+    clang \
     cmake \
     curl \
     cython3 \

contrib/build-wine.Dockerfile

@@ -1,4 +1,4 @@
-FROM debian:bookworm-slim
+FROM debian:bullseye-slim
 
 SHELL ["/bin/bash", "-c"]
 
@@ -15,7 +15,7 @@ RUN apt-get install -y \
 RUN dpkg --add-architecture i386
 RUN wget -nc https://dl.winehq.org/wine-builds/winehq.key
 RUN apt-key add winehq.key
-RUN echo "deb https://dl.winehq.org/wine-builds/debian/ bookworm main" >> /etc/apt/sources.list
+RUN echo "deb https://dl.winehq.org/wine-builds/debian/ bullseye main" >> /etc/apt/sources.list
 RUN apt-get update
 RUN apt-get install --install-recommends -y \
     wine-stable-amd64 \

contrib/build.Dockerfile

@@ -1,4 +1,4 @@
-FROM debian:buster-slim
+FROM debian:bullseye-slim
 
 SHELL ["/bin/bash", "-c"]
 
@@ -27,7 +27,7 @@ RUN apt-get install -y \
     libudev-dev \
     faketime \
     zip \
-    pyqt5-dev \
+    pyqt6-dev \
     libglib2.0-0
 
 RUN curl https://pyenv.run | bash

docs/examples/bitcoin-core-usage.rst

@@ -32,7 +32,7 @@ Clone Bitcoin Core and build it. Clone HWI.
     $ cd bitcoin
     $ cmake -B build
     $ cmake --build build
-    $ build/src/bitcoind -daemon -addresstype=bech32 -changetype=bech32
+    $ build/bin/bitcoind -daemon -addresstype=bech32 -changetype=bech32
     $ cd ..
     $ git clone https://github.com/bitcoin-core/HWI.git
     $ cd HWI

hwilib/devices/trezorlib/btc.py

@@ -19,7 +19,6 @@
 from decimal import Decimal
 from typing import TYPE_CHECKING, Any, AnyStr, Dict, List, Optional, Sequence, Tuple
 
-# TypedDict is not available in typing for python < 3.8
 from typing_extensions import TypedDict
 
 from . import exceptions, messages