Skip to content

test: diagnose LedgerX test failures #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test: diagnose LedgerX test failures #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions test/test_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,20 +586,12 @@ def test_signtx(self):
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
raise unittest.SkipTest("Coldcard sign test temporarily disabled")

if self.emulator.type == "ledger" and not self.emulator.legacy:
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
raise unittest.SkipTest("Test temporarily disabled for NanoX")

for addrtypes, multisig_types, external, op_return in self.signtx_cases:
with self.subTest(addrtypes=addrtypes, multisig_types=multisig_types, external=external, op_return=op_return):
self._test_signtx(addrtypes, multisig_types, external, op_return)

# Make a huge transaction which might cause some problems with different interfaces
def test_big_tx(self):
if self.emulator.type == "ledger" and not self.emulator.legacy:
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
raise unittest.SkipTest("Test temporarily disabled for NanoX")

# make a huge transaction
keypool_desc = self.do_command(self.dev_args + ["getkeypool", "--account", "10", "--addr-type", "sh_wit", "0", "100"])
import_result = self.wrpc.importdescriptors(keypool_desc)
Expand Down Expand Up @@ -630,10 +622,6 @@ def test_big_tx(self):

class TestDisplayAddress(DeviceTestCase):
def test_display_address_path(self):
if self.emulator.type == "ledger" and not self.emulator.legacy:
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
raise unittest.SkipTest("Test temporarily disabled for NanoX")

result = self.do_command(self.dev_args + ['displayaddress', "--addr-type", "legacy", '--path', 'm/44h/1h/0h/0/0'])
if self.emulator.supports_legacy:
self.assertNotIn('error', result)
Expand All @@ -659,10 +647,6 @@ def test_display_address_bad_path(self):
self.assertEqual(result['code'], -7)

def test_display_address_descriptor(self):
if self.emulator.type == "ledger" and not self.emulator.legacy:
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
raise unittest.SkipTest("Test temporarily disabled for NanoX")

account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/84h/1h/0h'])['xpub']
p2sh_segwit_account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/49h/1h/0h'])['xpub']
legacy_account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/44h/1h/0h'])['xpub']
Expand Down Expand Up @@ -784,10 +768,6 @@ def _check_sign_msg(self, msg):
self.assertTrue(self.rpc.verifymessage(addr, sig, msg))

def test_sign_msg(self):
if self.emulator.type == "ledger" and not self.emulator.legacy:
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
raise unittest.SkipTest("Test temporarily disabled for NanoX")

self._check_sign_msg("Message signing test")
self._check_sign_msg("285") # Specific test case for Ledger shorter S

Expand Down
Loading