Adding crash reporting libraries #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowp
reviewed
Aug 29, 2025
Comment on lines
71
to
73
| logScreenView('HomeScreen'); | ||
| logAppLaunchTTI(1.0); | ||
| showToast(`Logged: [${selectedLogLevel.toUpperCase()}]: Log emitted`); |
There was a problem hiding this comment.
From a testing perspective it has been been nice to include a bunch of the APIs and having mastro hit them for testing. We get no compile time safety that things are bound correctly (especially on the old arch), so having runtime testing has been helpful in catching issues
There might be other ways to test this, feel free to do some research
FranAguilera
force-pushed
the
franjam/react-native-crash-libraries
branch
3 times, most recently
from
7b37cbf to
3fe3a14
Compare
FranAguilera
changed the title
FranAguilera
force-pushed
the
franjam/react-native-crash-libraries
branch
2 times, most recently
from
a196a56 to
4e9ebae
Compare
FranAguilera
force-pushed
the
franjam/react-native-crash-libraries
branch
4 times, most recently
from
a1aed25 to
61fde74
Compare
kattrali
approved these changes
Sep 2, 2025
FranAguilera
force-pushed
the
franjam/react-native-crash-libraries
branch
from
f4f25da to
ac2925c
Compare
FranAguilera
force-pushed
the
franjam/react-native-crash-libraries
branch
from
ac2925c to
e7dac0b
Compare
FranAguilera
force-pushed
the
franjam/react-native-crash-libraries
branch
from
e7dac0b to
2345239
Compare
FranAguilera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves BIT-6250
Including crash reporting libraries to expo sample app and update layout to ease error testing. As a follow up will look how to trigger JVM crash for now on Android app