[WIP] Adding session start event #232
Conversation
| LOGGER_GUARD.with(|cell| { | ||
| if cell.try_borrow().is_ok() { | ||
| self.session_strategy.start_new_session(); | ||
| self.log_session_start(); |
There was a problem hiding this comment.
This only covers the case when a new session explicitly is started via the https://docs.bitdrift.io/sdk/features.html#generating-new-session-id call, we probably want this to also include the other ways in which a session is automatically started like on process start or activity expiration?
For the session metric we already emit I did this deep into the workflow engine as it already monitors for session change, but logging from there is a bit tricky so we probably need to think a bit about how it should work https://github.com/bitdriftlabs/shared-core/blob/main/bd-workflows/src/engine.rs#L504-L535
There was a problem hiding this comment.
thanks for the heads up, I was wondering about the rest as well. I see being useful where there is no new cold launch but def want to include for all session creation cases. Will investigate and report back
There was a problem hiding this comment.
should it be done inside bd-session module?
FranAguilera
changed the title
Part of BIT-5895, will follow up with frontend changes
Verification
https://timeline.bitdrift.dev/session/2b9b2616-2c0a-4e9e-bb60-c1a8d1c5ed23?utm_source=sdk&pages=1&utilization=0&expanded=1610211469249407351
Pending unit tests