shorten thread names #272
Merged
shorten thread names #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowp
approved these changes
Oct 8, 2025
| let cloned_shared_data = shared_data.clone(); | ||
| let flush_thread = std::thread::Builder::new() | ||
| .name(format!("bitdrift-buffer-{name}")) | ||
| .name(format!("bd-buffer-{name}")) |
There was a problem hiding this comment.
these will go over since the name is default_buffer or whatever it is, but not sure what else to put?
There was a problem hiding this comment.
RIP, not much we can do besides changing the default config at this point, since today they're called default_buffer_id and continuous_buffer
There was a problem hiding this comment.
regardless with truncation we should be able to tell bd-buffer-defau vs bd-buffer-conti so it's good enough for this purpose
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Linux thread names only supports 15 char limits, let's shorten our thread names to help with Android's profiling, e.g.
