feat: ACI-4001 add firefox to benchmark #166
Conversation
SummaryThis PR adds Firefox benchmark workflows to the CI pipeline. The changes include adding Firefox to the APPS list and creating corresponding benchmark workflows with various configurations (CC, DD, SPM combinations). However, there are critical configuration issues that need to be addressed. Walkthrough
|
| - xcode-build-for-simulator: | ||
| inputs: | ||
| - scheme: Fennec | ||
| - simulator_device: iPhone 17 | ||
| - xcodebuild_options: CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO |
There was a problem hiding this comment.
🐛 Bug
Missing project_path parameter in xcode-build-for-simulator step. Other Firefox workflows specify 'project_path: firefox-ios/Client.xcodeproj' but this baseline workflow is missing it, which could cause the build to fail or use the wrong project file.
🔄 Suggestion:
| - xcode-build-for-simulator: | |
| inputs: | |
| - scheme: Fennec | |
| - simulator_device: iPhone 17 | |
| - xcodebuild_options: CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO | |
| - xcode-build-for-simulator: | |
| inputs: | |
| - project_path: firefox-ios/Client.xcodeproj | |
| - scheme: Fennec | |
| - simulator_device: iPhone 17 | |
| - xcodebuild_options: CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO |
bitrise.yml
Outdated
| - xcode-build-for-simulator: | ||
| inputs: | ||
| - scheme: Fennec | ||
| - simulator_device: iPhone 17 |
There was a problem hiding this comment.
🐛 Bug
Inconsistent simulator specification. The baseline workflow uses 'simulator_device: iPhone 17' while other Firefox workflows use 'destination: platform=iOS Simulator,name=iPhone 17,OS=26.0'. This inconsistency could cause different build behavior or failures.
🔄 Suggestion:
| - simulator_device: iPhone 17 | |
| - destination: 'platform=iOS Simulator,name=iPhone 17,OS=26.0' |
| - bundle::benchmark_start_measure: | ||
| inputs: | ||
| - BENCHMARK_APP_NAME: $BENCHMARK_APP_NAME | ||
| - xcode-build-for-simulator: |
There was a problem hiding this comment.
🐛 Bug
The Firefox baseline workflow is missing the configuration parameter that other workflows have, which could cause build inconsistencies.
🔄 Suggestion:
| - xcode-build-for-simulator: | |
| - xcode-build-for-simulator: | |
| inputs: | |
| - project_path: firefox-ios/Client.xcodeproj | |
| - scheme: Fennec | |
| - configuration: Debug | |
| - destination: 'platform=iOS Simulator,name=iPhone 17,OS=26.0' | |
| - xcodebuild_options: CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO |
| - bundle::benchmark_start_measure: | ||
| inputs: | ||
| - BENCHMARK_APP_NAME: $BENCHMARK_APP_NAME | ||
| - xcode-build-for-simulator: |
There was a problem hiding this comment.
🐛 Bug
The Firefox CC workflow is missing the configuration parameter that other workflows have, which could cause build inconsistencies.
🔄 Suggestion:
| - xcode-build-for-simulator: | |
| - xcode-build-for-simulator: | |
| inputs: | |
| - project_path: firefox-ios/Client.xcodeproj | |
| - scheme: Fennec | |
| - configuration: Debug | |
| - destination: 'platform=iOS Simulator,name=iPhone 17,OS=26.0' | |
| - xcodebuild_options: CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO |
No description provided.