-
Notifications
You must be signed in to change notification settings - Fork 8
Add convenience method to create a tracker in steps #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mateherber
wants to merge
5
commits into
master
Choose a base branch
from
create-step-analytics-tracker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bdd0c7e
Add convenience method to create a tracker in steps
1d7d51d
Fix `errcheck` errors
d35a3bb
Merge branch 'master' into create-step-analytics-tracker
russellbstephens d5da4f2
Update analytics/track.go
lpusok 56474dc
Merge branch 'master' into create-step-analytics-tracker
lpusok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package analytics | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/bitrise-io/go-utils/v2/analytics" | ||
| "github.com/bitrise-io/go-utils/v2/env" | ||
| ) | ||
|
|
||
| // TrackerFactory ... | ||
| type TrackerFactory func(...analytics.Properties) analytics.Tracker | ||
|
|
||
| const ( | ||
| stepExecutionIDEnvKey = "BITRISE_STEP_EXECUTION_ID" | ||
| stepExecutionID = "step_execution_id" | ||
| ) | ||
|
|
||
| // NewStepTracker ... | ||
| func NewStepTracker(repository env.Repository, trackerFactory TrackerFactory) (analytics.Tracker, error) { | ||
| id := repository.Get(stepExecutionIDEnvKey) | ||
| if id == "" { | ||
| return nil, fmt.Errorf("no step execution ID found") | ||
| } | ||
| return trackerFactory(analytics.Properties{stepExecutionID: id}), nil | ||
| } | ||
|
|
||
| // NewDefaultStepTracker ... | ||
| func NewDefaultStepTracker(repository env.Repository) (analytics.Tracker, error) { | ||
| return NewStepTracker(repository, analytics.NewDefaultTracker) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package analytics | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/bitrise-io/go-steputils/v2/analytics/mocks" | ||
| "github.com/bitrise-io/go-utils/v2/analytics" | ||
| ) | ||
|
|
||
| func TestNewStepTrackerFailsIfStepExecutionIDIsNotFound(t *testing.T) { | ||
| repository := new(mocks.Repository) | ||
| repository.On("Get", "BITRISE_STEP_EXECUTION_ID").Return("") | ||
| _, err := NewDefaultStepTracker(repository) | ||
| if err == nil { | ||
| t.Error("Expected error, got nil") | ||
| } | ||
| } | ||
|
|
||
| func TestNewStepTrackerAddsStepExecutionIDToNewTracker(t *testing.T) { | ||
| repository := new(mocks.Repository) | ||
| repository.On("Get", "BITRISE_STEP_EXECUTION_ID").Return("123") | ||
| factory := new(mocks.TrackerFactory) | ||
| factory.On("Execute", analytics.Properties{"step_execution_id": "123"}).Return(nil, nil) | ||
| _, err := NewStepTracker(repository, factory.Execute) | ||
| if err != nil { | ||
| t.Errorf("Expected no error, got %s", err) | ||
| } | ||
| factory.AssertExpectations(t) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.