Skip to content

fix https://github.com/bits-and-blooms/bloom/issues/104 issue #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix https://github.com/bits-and-blooms/bloom/issues/104 issue #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion bloom.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,27 @@ func (f *BloomFilter) ApproximatedSize() uint32 {
x := float64(f.b.Count())
m := float64(f.Cap())
k := float64(f.K())
size := -1 * m / k * math.Log(1-x/m) / math.Log(math.E)

if x == 0 {
return 0 // If no bit is set, returns 0
}

ratio := x / m
if ratio >= 1.0 {
return math.MaxUint32 // If all bits are set, returns the maximum value
}

// To prevent floating point precision issues, ensure ratio does not exceed 1
if ratio > 1.0 {
ratio = 1.0
}

size := -m / k * math.Log(1-ratio)

// Check for overflow
if size > float64(math.MaxUint32) {
return math.MaxUint32
}
return uint32(math.Floor(size + 0.5)) // round
}

Expand Down