Example: merge ciphers clients create #467

coroiu · 2025-09-22T09:46:16Z

🎟️ Tracking

📔 Objective

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

## 🎟️ Tracking  ## 📔 Objective These crates had some missing features, which caused compilation errors when trying to run the tests from VSCode. The reason that CI kept building was that rust unifies all the workspace features, so as long as one crate has them enabled it's fine. On the other hand, when running a test from VSCode, it will only have that crates features in mind. Note that the uniffi feature of core requires internal because of these two types: https://github.com/bitwarden/sdk-internal/blob/main/crates/bitwarden-core/src/uniffi_support.rs#L30-L42 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes

Scaffolds a new workflow for updating API bindings.

Updated SDK to use an `archivedDate` in the ciphers.

This adds two custom dylint lint. - `error_suffix`: Requires all types that implements `Error` ends with an `Error` suffix. - `error_enum`: Forbids ending enum error variants with `Error`.

Wraps up the b64 migration.

We removed the ability to throw `VaultLocked` a while back. This removes the actual error struct and any place it's used in.

github-actions · 2025-09-22T09:51:16Z

Checkmarx One – Scan Summary & Details – dc9cec00-e6f5-4b3b-a811-c47ab329e3d0

Great job! No new security vulnerabilities introduced in this pull request

sonarqubecloud · 2025-09-22T09:51:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-09-22T10:02:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.33%. Comparing base (0c568a0) to head (c8078c7).

Additional details and impacted files

@@                    Coverage Diff                    @@
##           vault/migrate-ciphers     #467      +/-   ##
=========================================================
+ Coverage                  78.18%   78.33%   +0.15%     
=========================================================
  Files                        278      278              
  Lines                      28204    28206       +2     
=========================================================
+ Hits                       22052    22096      +44     
+ Misses                      6152     6110      -42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gbubemismith · 2025-09-22T13:34:09Z

crates/bitwarden-vault/src/cipher/cipher_client/create.rs

+        let settings = ClientSettings {
+            identity_url: format!("http://{}/identity", mock_server.address()),
+            api_url: format!("http://{}/api", mock_server.address()),
+            user_agent: "Bitwarden Rust-SDK [TEST]".into(),
+            device_type: DeviceType::SDK,
+        };


Nice. I see where I missed it. I initially started with something similar

gbubemismith and others added 21 commits September 15, 2025 09:39

Added conversions for ciphers

d5fb7b2

Added create, edit and get

8144b98

Exposed through cipher client

0734d40

Scaffold workflow for generating api bindings (#441)

0535582

Scaffolds a new workflow for updating API bindings.

[PM-23193] Add ArchivedDate (#422)

d008260

Updated SDK to use an `archivedDate` in the ciphers.

Add dylint lints for errors (#430)

d204e42

This adds two custom dylint lint. - `error_suffix`: Requires all types that implements `Error` ends with an `Error` suffix. - `error_enum`: Forbids ending enum error variants with `Error`.

Migrate more b64 (#411)

9a8d482

Wraps up the b64 migration.

Remove unused vault locked error (#440)

778c3ac

We removed the ability to throw `VaultLocked` a while back. This removes the actual error struct and any place it's used in.

Set default values

09af3cb

Added todo's

298b336

Added archived date to request and response

841f40a

Fixed merge conflicts

17cecd8

Removed error

9d27d7f

Added list with failures

d219627

fixed lint issues

c1fcadc

removed error

2b8491a

restructured cipher client to sub folders

a0bca6b

updated edit

0c568a0

feat: merge ciphers client create

c8078c7

coroiu mentioned this pull request Sep 22, 2025

[PM-25818] Migrate Basic Cipher Create, Edit, and Get Operations to SDK #455

Merged

gbubemismith reviewed Sep 22, 2025

View reviewed changes

Base automatically changed from vault/migrate-ciphers to main October 21, 2025 21:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Example: merge ciphers clients create #467

Example: merge ciphers clients create #467

coroiu commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

Uh oh!

sonarqubecloud bot commented Sep 22, 2025

Uh oh!

codecov bot commented Sep 22, 2025

Uh oh!

gbubemismith Sep 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Example: merge ciphers clients create #467

Are you sure you want to change the base?

Example: merge ciphers clients create #467

Conversation

coroiu commented Sep 22, 2025

🎟️ Tracking

📔 Objective

⏰ Reminders before review

🦮 Reviewer guidelines

Uh oh!

github-actions bot commented Sep 22, 2025

Great job! No new security vulnerabilities introduced in this pull request

Uh oh!

sonarqubecloud bot commented Sep 22, 2025

Quality Gate passed

Uh oh!

codecov bot commented Sep 22, 2025

Codecov Report

Uh oh!

gbubemismith Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants