Skip to content

Conversation

cd-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1591

📔 Objective

Create the appropriate entity, entity type configuration, and database context changes to use the SecretVersion table described above.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cd-bitwarden cd-bitwarden marked this pull request as ready for review October 1, 2025 16:17
@cd-bitwarden cd-bitwarden requested a review from a team as a code owner October 1, 2025 16:17
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.56%. Comparing base (14aa450) to head (0dc1396).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/SecretsManager/Entities/SecretVersion.cs 0.00% 12 Missing ⚠️
...tyFramework/SecretsManager/Models/SecretVersion.cs 66.66% 3 Missing ⚠️
...re.EntityFramework/SecretsManager/Models/Secret.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6406      +/-   ##
==========================================
+ Coverage   50.42%   50.56%   +0.13%     
==========================================
  Files        1853     1856       +3     
  Lines       82394    82211     -183     
  Branches     7265     7261       -4     
==========================================
+ Hits        41550    41569      +19     
+ Misses      39260    39054     -206     
- Partials     1584     1588       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Oct 1, 2025

Logo
Checkmarx One – Scan Summary & Detailsa0eb2f70-b80e-4747-9f2d-45f5c1f55eb5

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH Path_Traversal /src/Api/Billing/Controllers/VNext/SelfHostedAccountBillingController.cs: 27
detailsMethod at line 27 of /src/Api/Billing/Controllers/VNext/SelfHostedAccountBillingController.cs gets dynamic data from the user element. This elem...
ID: wtYI1weWr%2BeAKPCeuxQzQkZmaWU%3D
Attack Vector
MEDIUM Use_Of_Hardcoded_Password /src/Core/Constants.cs: 144
detailsThe application uses the hard-coded password CipherRepositoryBulkResourceCreation for authentication purposes, either using it to verify users' id...
ID: YHm9AW4BTju0uPgxnW9f45nty6E%3D
Attack Vector
Fixed Issues (1)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Billing/Controllers/VNext/AccountBillingVNextController.cs: 60

Copy link

sonarqubecloud bot commented Oct 3, 2025

Copy link

@mkincaid-bw mkincaid-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the EF migrations will create tables with plural names (ie: SecretVersions instead of SecretVersion. I've made comments on the util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs file but the same changes should be applied to the Postgres and Sqlite files as well.

Copy link

@mkincaid-bw mkincaid-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions

Copy link

@mkincaid-bw mkincaid-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions on some of the Sqlite files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks like a duplicate of 20251009152635_CreatingSecretVersionTables.cs?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks like a duplicate of 20251009152635_CreatingSecretVersionTables.Designer.cs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants