-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[SM-1591] Adding SecretVersion table to server #6406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6406 +/- ##
==========================================
+ Coverage 50.42% 50.56% +0.13%
==========================================
Files 1853 1856 +3
Lines 82394 82211 -183
Branches 7265 7261 -4
==========================================
+ Hits 41550 41569 +19
+ Misses 39260 39054 -206
- Partials 1584 1588 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the EF migrations will create tables with plural names (ie: SecretVersions
instead of SecretVersion
. I've made comments on the util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
file but the same changes should be applied to the Postgres and Sqlite files as well.
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/MySqlMigrations/Migrations/20251001154948_CreateSecretVersionsTable.cs
Outdated
Show resolved
Hide resolved
util/SqliteMigrations/Migrations/20251007175440_SecretVersionAddingTablesAndFK.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions
util/MySqlMigrations/Migrations/DatabaseContextModelSnapshot.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions on some of the Sqlite files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file looks like a duplicate of 20251009152635_CreatingSecretVersionTables.cs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file looks like a duplicate of 20251009152635_CreatingSecretVersionTables.Designer.cs
?
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1591
📔 Objective
Create the appropriate entity, entity type configuration, and database context changes to use the SecretVersion table described above.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes