Skip to content

Conversation

harr1424
Copy link
Contributor

@harr1424 harr1424 commented Oct 6, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-24747?atlOrigin=eyJpIjoiMWI3NTRkOTM2MzkwNDIzYmE4OGRhZDQ4NGQ3MDYwNTYiLCJwIjoiaiJ9

๐Ÿ“” Objective

Remove feature flag โ€œpm-23982-chromium-importer" from server and clients

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 6, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 55573bec-413d-40e2-bbed-7213a8d9cb3e

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โš ๏ธ Please upload report for BASE (main@f75ad36). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6415   +/-   ##
=======================================
  Coverage        ?   50.35%           
=======================================
  Files           ?     1853           
  Lines           ?    82393           
  Branches        ?     7265           
=======================================
  Hits            ?    41490           
  Misses          ?    39320           
  Partials        ?     1583           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@djsmith85 djsmith85 added hold Hold this PR or item until later; DO NOT MERGE and removed hold Hold this PR or item until later; DO NOT MERGE labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants