Skip to content

Conversation

maxkpower
Copy link

📔 Objective

Move PhishingDomainFeatures from Core to Core/Dirt team ownership

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@maxkpower maxkpower requested a review from a team as a code owner October 7, 2025 21:53
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-26665
Link: https://bitwarden.atlassian.net/browse/PM-26665

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title move PhishingDomainFeatures to Dirt team ownership [PM-26665] move PhishingDomainFeatures to Dirt team ownership Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Logo
Checkmarx One – Scan Summary & Details1c50a663-21d9-4518-bab5-f8e540614e1e

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.42%. Comparing base (876a213) to head (808c667).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6427   +/-   ##
=======================================
  Coverage   50.42%   50.42%           
=======================================
  Files        1853     1853           
  Lines       82394    82394           
  Branches     7265     7265           
=======================================
  Hits        41550    41550           
  Misses      39260    39260           
  Partials     1584     1584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants