IALERT-3123: Unset the Preset Channel in Distribution Job Creation #2695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IALERT-3123 deals with not showing a warning immediately when a user lands on the Distribution Job creation form. This warning shows because the channel would be preset when the form renders on the page, but the Provider was not set. After some talks with the Alert team, we want to proactively counteract this by not presetting the channel on form render.
Technical Description
In the
DistributionConfigurationForm
, we no longer preset the channel. The preset channel is just an empty string rather than Azure Board. I'm not sure why it was preset in the past, my assumption is that it's the first in the list of selectable options for channels. Regardless, unsetting the channel on form render no longer renders the channel part of the form (bottom part of the form that changes when the user changes the selected channel). Now when the form renders there is no warning displayed and the form looks like the attached screenshot.