Skip to content

POC: Reuse nuget dependencies and external IDs for more optimal memory usage. #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

POC: Reuse nuget dependencies and external IDs for more optimal memory usage. #1109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...m/synopsys/integration/detectable/detectables/nuget/parse/NugetDependencyNodeBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
package com.synopsys.integration.detectable.detectables.nuget.parse;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import com.synopsys.integration.bdio.graph.BasicDependencyGraph;
import com.synopsys.integration.bdio.graph.DependencyGraph;
import com.synopsys.integration.bdio.model.Forge;
import com.synopsys.integration.bdio.model.dependency.Dependency;
import com.synopsys.integration.bdio.model.externalid.ExternalId;
import com.synopsys.integration.detectable.detectables.nuget.model.NugetPackageId;
import com.synopsys.integration.detectable.detectables.nuget.model.NugetPackageSet;

public class NugetDependencyNodeBuilder {
private static Map<ExternalId, Dependency> externalIdToDependencyMap = new HashMap<>();
private final List<NugetPackageSet> packageSets = new ArrayList<>();

public void addPackageSets(List<NugetPackageSet> sets) {
Expand Down Expand Up @@ -38,6 +42,14 @@ public DependencyGraph createDependencyGraph(List<NugetPackageId> packageDepende
}

private Dependency convertPackageId(NugetPackageId id) {
return Dependency.FACTORY.createNameVersionDependency(Forge.NUGET, id.name, id.version);
Dependency d = Dependency.FACTORY.createNameVersionDependency(Forge.NUGET, id.name, id.version);
ExternalId ei = d.getExternalId();

if (externalIdToDependencyMap.containsKey(ei)) {
d = externalIdToDependencyMap.get(ei);
} else {
externalIdToDependencyMap.put(ei, d);
}
return d;
}
}