Add test case for remove_dupes with SQL_ASCII test case #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 2, 2017 16:44
test/unit/svn_commits_test.rb
Outdated
| @@ -110,7 +110,7 @@ def test_remove_dupes_with_sql_acii_encoding | |||
| #Note: If there are two files that are identical except for the encoding, ohloh_scm should only keep one. | |||
| svn = SvnAdapter.new | |||
| diff_1 = OhlohScm::Diff.new(:action => "M", :path => "/FritzBoxDial/FritzBoxDial/formWählbox.vb") | |||
| diff_2 = OhlohScm::Diff.new(:action => "A", :path => "/FritzBoxDial/FritzBoxDial/formW\xC3\xA4hlbox.vb".force_encoding('ASCII')) | |||
| diff_2 = OhlohScm::Diff.new(:action => "A", :path => "/FritzBoxDial/FritzBoxDial/formWählbox.vb") | |||
There was a problem hiding this comment.
This doesn't verify the scenario, does it? There are two different actions, "Modify" and "Add", but the same file, "/FritzBoxDial/FritzBoxDial/formWählbox.vb" without any difference in representation -- that is, both are UTF8, whereas the removed line used Unicode encoding, which is what we saw in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.