Skip to content

Conversation

@c-w-m
Copy link

@c-w-m c-w-m commented Jan 13, 2023

SSLError #346 final

  • implementation of new arg (--verify <CA_BUNDLE> to allow requests.get setting of verify arg

  • testing updates

    • testing exposed one error (ommision) in the implementation which was fixed ;-)
    • added import dotnet used with testing to allow .env.test file for setting CA_BUNDLE environment variable
    • added tests_requirements to setup.py to support $ python setup.py test
    • added requirements-dev.txt to support development (includes black for formatting)
    • new settings.py file used in testing to read in either environment variable or .env.test variable
    • tox file revised to now include py3.10 and a development build of py3.11
    • /.github/workflow/tests.yml were not updated (they still have python-version: [3.7, 3.8, 3.9, pypy-3.7])
  • doc updates

    • README.rst has new --verify option
    • CONTRIBUTING.rst note that 3.7 to 3.10 should pass (3.11 needs work)
  • final tox runs attached

  • .vscode directory added (it can be ignored if not of interest, my bad)

Cheers


last bit/suggestion

  • update CONTRIBUTING.rst with note on setting CA_BUNDLE if needed (see below)
  • and capture the results to a file to submit with pull request
  1. When you're done making changes, check that your changes pass flake8 and the tests, including testing other Python versions with tox::

    $ flake8 pipreqs tests > flake8_pipreqs_tests_results.txt

  • if needed, set the CA_BUNDLE value in the .env.test file located in tests/ (or set an environment variable)

    $ python setup.py test > python_setup_tests_pipreqs_results.txt

    $ tox > tox_pipreqs_results.txt

@c-w-m c-w-m changed the title Tox test fix for SSLError - new arg --verify <CA_BUNDLE> Jan 14, 2023
@jonas-eschle
Copy link
Collaborator

Thanks also for this PR! What do you think, should we still add this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants