Skip to content

Conversation

firilisinof
Copy link
Contributor

@firilisinof firilisinof commented Sep 21, 2023

This PR creates a test for the output_requirements function.

  • Take advantage of the fact that the file creation has already been tested by comparing it with the standard output (captured previously).

Copy link
Collaborator

@alan-barzilay alan-barzilay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont forget to rebase your PR

@firilisinof
Copy link
Contributor Author

I just updated the PR description with more details.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@cebc3f7). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #395   +/-   ##
=======================================
  Coverage        ?   89.27%           
=======================================
  Files           ?        2           
  Lines           ?      261           
  Branches        ?        0           
=======================================
  Hits            ?      233           
  Misses          ?       28           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alan-barzilay alan-barzilay merged commit acc41cc into bndr:next Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants