-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add Antora and AsciiDoc preview scripts #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
An automated preview of the documentation is available at https://126.boostlook.prtest2.cppalliance.org/tools/boostlook/doc/html/index.html |
157fd33 to
4250ed1
Compare
|
An automated preview of the documentation is available at https://126.boostlook.prtest2.cppalliance.org/tools/boostlook/doc/html/index.html |
|
These issues with ./boostlook_asciidoc_preview.rb Some warnings/errors appeared, mentioned in Slack. Maybe not a concern.
The above steps could be included within the script itself in a text ./boostlook_antora_preview.rb minor warnings. again, perhaps add text instructions. |
|
@sdarwin Thanks for reviewing & the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Julio for both sets of preview scripts.
- We ran into issues with asciidoctor but antorra worked as expected
- The answer to the asciidoctor problem was to move the user-config.jam into my /Users/kskinner directory. We then had to add the following to that file. Once we did that, all worked as expected.
Use the full path to the asciidoctor executable found by 'which'
using asciidoctor : /usr/local/bin/asciidoctor ;
- The updated documentation (development.md and readme.md) incorporates steps that you need to do to install and use the preview tool. I think the problem I had was self-induced. That said, we can add to the troubleshooting section with how to address.
Ready to go to develop/staging.
|
Notice what Kari wrote: Create or modify the file Use the full path to the asciidoctor executable found by 'which'
That should be in the doc. It was only after this step that I got a preview to launch in a browser. Before, it said: |
4250ed1 to
694c6d3
Compare
|
An automated preview of the documentation is available at https://126.boostlook.prtest2.cppalliance.org/tools/boostlook/doc/html/index.html |
694c6d3 to
9acca53
Compare
|
@karimarie67 @sdarwin How do we feel about adding this? This is in latest commit Preview with AsciiDoc Requirements
TroubleshootingPreview with AsciiDoc IssuesError:
Error:
Script must be run from the project root
Warnings like
|
|
An automated preview of the documentation is available at https://126.boostlook.prtest2.cppalliance.org/tools/boostlook/doc/html/index.html |
@karimarie67 , @julioest , from your testing, do previews function correctly from a stand-alone boostlook folder, or must they be located in a certain folder. Example 1. cd $HOME/boostlook/ . Run previews. Example 2. cd $HOME/github/boost/tools/boostlook/ . Run previews. Do both of those work for you? |
|
@sdarwin Yes, works for me |
|
For me, example 2 works. Example 1 shows this: If you go through the setup, starting at the very beginning, in a fresh docker container... it might not be able to display the preview because a browser is missing. But otherwise, at least, it should get past the "b2" errors, and then maybe get to the browser errors. If you hit b2 errors it replicates the problem. Could you try it? What results did @karimarie67 get? Or, maybe I missed a setup step that you and Kari have done correctly. |
|
I think that I discovered the problem. There are two ways to put
I was doing the first one, but that's wrong, it seems to only accept the second choice. So maybe update the instructions, since it's not enough to say "b2 is on the PATH." It must be "modify your PATH variable to include the current location of |
Summary
Streamlines development workflow by consolidating documentation and improving script naming clarity.
References #118
Changes
Preview scripts:
boostlook_preview.rb→boostlook_asciidoc_preview.rbboostlook_antora_preview.rbConsolidate documentation:
DEVELOPMENT.mdREADME.mdto project overview onlyBenefits
Testing