Skip to content

Workaround clang bug with basic_string_view #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Workaround clang bug with basic_string_view #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3a133e
Add reproducer for Clang < 15 bug with string_view & C++11 char types
Flamefire Jan 4, 2025
e5e0c50
Workaround clang bug
Flamefire Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/boost/core/detail/string_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ template<class Ch> class basic_string_view

template<class A> operator std::basic_string<Ch, std::char_traits<Ch>, A>() const
{
return std::basic_string<Ch, std::char_traits<Ch>, A>( data(), size() );
return std::basic_string<Ch, std::char_traits<Ch>, A>( begin(), end() );
}

#if !defined(BOOST_NO_CXX17_HDR_STRING_VIEW)
Expand Down
33 changes: 33 additions & 0 deletions test/sv_conversion_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,29 @@ boost::core::string_view f( boost::core::string_view const& str )
return str;
}

template<typename Char>
boost::core::basic_string_view<Char> f( boost::core::basic_string_view<Char> const& str )
{
return str;
}

template<typename Char>
void subtest()
{
std::basic_string<Char> s1( 3, Char('1') );
s1[1] = Char('2');
s1[2] = Char('3');

std::basic_string<Char> s2 = f<Char>( s1 );
BOOST_TEST( s1 == s2 );

#if ! (defined(BOOST_CLANG) && BOOST_CLANG_VERSION < 150000)
// leads to undefined symbols in Clang < 15: https://github.com/llvm/llvm-project/issues/55560
std::basic_string<Char> s3( (f<Char>( s1 )) );
BOOST_TEST( s1 == s3 );
#endif
}

int main()
{
{
Expand Down Expand Up @@ -62,5 +85,15 @@ int main()

#endif

#if !defined(BOOST_NO_CXX11_CHAR16_T)
subtest<char16_t>();
#endif
#if !defined(BOOST_NO_CXX11_CHAR32_T)
subtest<char32_t>();
#endif
#if defined(__cpp_char8_t) && __cpp_char8_t >= 201811L
subtest<char8_t>();
#endif

return boost::report_errors();
}
Loading