Skip to content

Annotate facade header with IWYU export annotation #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Annotate facade header with IWYU export annotation #1427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/boost/geometry/geometry.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#ifndef BOOST_GEOMETRY_GEOMETRY_HPP
#define BOOST_GEOMETRY_GEOMETRY_HPP

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to add a comment (one or two sentences) giving the background,
like you did in the PR (maybe more concise). Otherwise this will raise questions after a year or two (by possibly new developers).

// IWYU pragma: begin_exports

#include <boost/config.hpp>

#if defined(BOOST_NO_CXX14_CONSTEXPR)
Expand Down Expand Up @@ -134,4 +136,6 @@
#include <boost/geometry/algorithms/is_convex.hpp>
#include <boost/geometry/algorithms/point_on_surface.hpp>

// IWYU pragma: end_exports

#endif // BOOST_GEOMETRY_GEOMETRY_HPP