Skip to content

refactor: Move base_channel_type_impl to detail namespace #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

refactor: Move base_channel_type_impl to detail namespace #681

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0027e0
refactor: Move base_channel_type_impl to detail namespace
marco-langer Jun 4, 2022
3714636
Merge remote-tracking branch 'origin/develop' into refactor-base_chan…
mloskot Jun 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/boost/gil/channel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,9 @@ void swap(const boost::gil::packed_dynamic_channel_reference<BF,NB,M> x, const b

// \brief Determines the fundamental type which may be used, e.g., to cast from larger to smaller channel types.
namespace boost { namespace gil {

namespace detail {

template <typename T>
struct base_channel_type_impl { using type = T; };

Expand All @@ -715,8 +718,10 @@ template <typename ChannelValue, typename MinV, typename MaxV>
struct base_channel_type_impl<scoped_channel_value<ChannelValue, MinV, MaxV> >
{ using type = ChannelValue; };

} // namespace detail

template <typename T>
struct base_channel_type : base_channel_type_impl<typename std::remove_cv<T>::type> {};
struct base_channel_type : detail::base_channel_type_impl<typename std::remove_cv<T>::type> {};

}} //namespace boost::gil

Expand Down