Skip to content

Conversation

marco-langer
Copy link
Contributor

Description

This PR implements the channel traits min and max values for binary, truncate and adaptive thresholds and thereby extends the possible pixel types for these algorithms.

The current test cases are all green, but I will also add new test cases for floating point types and signed integer types soon.

References

Closes #697

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@marco-langer marco-langer marked this pull request as draft June 27, 2022 19:05
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.94%. Comparing base (4dbf35a) to head (f37758d).
⚠️ Report is 81 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #701   +/-   ##
========================================
  Coverage    80.93%   80.94%           
========================================
  Files          116      116           
  Lines         5130     5132    +2     
========================================
+ Hits          4152     4154    +2     
  Misses         978      978           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marco-langer marco-langer force-pushed the fix-threshold-min-max branch from a44ed0d to d7b82fc Compare June 28, 2022 07:13
@marco-langer marco-langer force-pushed the fix-threshold-min-max branch from d7b82fc to f37758d Compare June 28, 2022 16:39
@mloskot mloskot added this to the Boost 1.81+ milestone Jul 7, 2022
@mloskot mloskot modified the milestones: Boost 1.82, Boost 1.83+ Mar 31, 2023
@mloskot mloskot modified the milestones: Boost 1.86, 1.87.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix wrong pixel channel truncation in binary threshold and truncate threshold
2 participants