Skip to content

Conversation

bratpiorka
Copy link
Owner

@bratpiorka bratpiorka commented Aug 6, 2025

add memory properties API


This change is Reviewable

Copy link

@lplewa lplewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 35 files reviewed, 2 unresolved discussions


src/provider/provider_cuda.c line 753 at r1 (raw file):

    void *provider, const void *ptr,
    umf_memory_property_id_t memory_property_id, void *value,
    size_t max_property_size) {

Please remove this argument (or find a usecase for it)


src/memory_props.c line 144 at r1 (raw file):

    case UMF_MEMORY_PROPERTY_CONTEXT:
    case UMF_MEMORY_PROPERTY_DEVICE:
        return provider->ops.ext_get_allocation_properties(

Just break - and go to the code bellow (or add check if ops is not null

sarnex and others added 2 commits August 6, 2025 08:43
[CMake] Support preinstalled googlebenchmark
Copy link

@lplewa lplewa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 35 files reviewed, 2 unresolved discussions


src/provider/provider_level_zero.c line 883 at r2 (raw file):

    (void)ptr;

    struct ze_memory_provider_t *ze_provider =

Null check?


src/provider/provider_level_zero.c line 911 at r2 (raw file):

    // unused
    (void)provider;

NIT: provider param is technically also not needed. but maybe it should stay for consistency with other functions.. Not sure.

@bratpiorka bratpiorka force-pushed the rrudnick_props_api branch 4 times, most recently from 0be027c to a7ca9f6 Compare August 7, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants