Skip to content

Fixed problems with color ANSI sequences and ported to Cygwin #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed problems with color ANSI sequences and ported to Cygwin #2

wants to merge 2 commits into from

Conversation

gavenkoa
Copy link

No description provided.

@gavenkoa
Prevent parsing errors due to ANSI control sequences emitted by default.
a584c6e 
At least "vagrant global-status | od -c" produces:

    \n 033   [   0   m   -   -

before delimiter ----...-- ID so regex /^-+$/ is failed.

There is --no-color flag but I am not sure about backward compatibility.

So ended with VAGRANT_NO_COLOR env var which is the most unintrusive way to
introduce fix.

https://www.vagrantup.com/docs/other/environmental-variables.html
@gavenkoa
Prevent parsing errors due to trailing \r (CR) sign when completion w…
682ec00 
…orks

within Cygwin's Bash with native Windows build of Vagrant.

# vagrant help | od -c
\r  \n  \r  \n        -   v   ,       -   -   v   e   r  s  i  o  n

It is possible to strip \r by piping through 'tr -d $"\n"' at cost of extra
process but completion is already slow on Windows so it's better to handle
CR in awk at cost of readability.

Only __vagrant_get_snapshots wasn't updated as I found it difficult to test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gavenkoa