Add delete operation to core workflow #1724
Open
+73
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavskalyan
reviewed
Sep 26, 2024
|
Does this work? What is required to get this merged? Happy to help with anything. |
Unfortunately, I wasn't able to get it to work yet. Feel free to locally pull and try it out |
|
A bit confused on what does/ doesn't work, do deletes exist at all? Is it just sometimes the indices are messed up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide delete operation in core workflow.
AcknowledgedCounterGenerator's constructor is taking incountstart. The existing code does not behave correctly asinsertcountcan have negative integer value.insertcount = recordcount - insertstart. if user configuresinsertstart = 200andrecordcount = 100,insertcountis -100