Skip to content

Add get_loftee_end_trunc_filter_expr and update_loftee_end_trunc_filter to patch the LOFTEE END_TRUNC filter #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 30, 2025
Merged

Add get_loftee_end_trunc_filter_expr and update_loftee_end_trunc_filter to patch the LOFTEE END_TRUNC filter #740

merged 9 commits into from
Sep 30, 2025

Conversation

jkgoodrich
Copy link
Contributor

Tested in this notebook
test_loftee_end_trunc.html.zip

@jkgoodrich jkgoodrich self-assigned this Nov 28, 2024
@jkgoodrich jkgoodrich requested a review from KoalaQin December 2, 2024 16:56
KoalaQin
KoalaQin reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@KoalaQin KoalaQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two minor comments.

@jkgoodrich
Merge branch 'main' of https://github.com/broadinstitute/gnomad_methods…
0423f75 
… into jg/determine_end_trunc_filter_from_gerp
@jkgoodrich
Merge branch 'main' of https://github.com/broadinstitute/gnomad_methods…
49d621f 
… into jg/determine_end_trunc_filter_from_gerp
@jkgoodrich jkgoodrich requested a review from a team as a code owner September 24, 2025 20:49
@jkgoodrich jkgoodrich assigned klaricch and unassigned KoalaQin Sep 24, 2025
@jkgoodrich jkgoodrich requested a review from klaricch September 24, 2025 22:14
klaricch
klaricch approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@klaricch klaricch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but just a note to add tests since these are in the gnomad methods repo

@jkgoodrich jkgoodrich requested a review from klaricch September 25, 2025 20:32
klaricch
klaricch reviewed Sep 30, 2025
View reviewed changes
klaricch
klaricch reviewed Sep 30, 2025
View reviewed changes
@jkgoodrich jkgoodrich merged commit 52a49c8 into main Sep 30, 2025
6 checks passed
@jkgoodrich jkgoodrich deleted the jg/determine_end_trunc_filter_from_gerp branch September 30, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaricch klaricch klaricch approved these changes

+1 more reviewer

@KoalaQin KoalaQin KoalaQin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@klaricch klaricch

@jkgoodrich jkgoodrich

Labels
Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkgoodrich @klaricch @KoalaQin