Add function for exploding intervals to loci #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch-kr
requested changes
Jul 3, 2025
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
ch-kr
reviewed
Jul 11, 2025
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
ch-kr
reviewed
Jul 14, 2025
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
Co-authored-by: Katherine Chao <[email protected]>
|
a little late, but I also forgot that we've been requesting that each person who adds or changes code in this repo add tests (https://github.com/broadinstitute/gnomad_methods/tree/main/tests). could you add tests for this new function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Addition:
Added a function in
intervals.pywhich explodes hail intervals into per base loci, keeping same reference genome as original interval.Optionally it can return the original interval that the locus belongs to or drop it from the exploded table.