-
Notifications
You must be signed in to change notification settings - Fork 64
Fix uncontrolled data used in path expression #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
opsysdebug
wants to merge
1
commit into
browserstack:master
Choose a base branch
from
opsysdebug:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangecurl
approved these changes
Aug 24, 2025
poratoes
approved these changes
Aug 24, 2025
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447247
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447248
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447249
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447254
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447252
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447253
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447257
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447256
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447258
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447259
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447261
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447260
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447262
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447263
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447264
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447265
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447266
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447267
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447268
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447269
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447270
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447271
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447272
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447273
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447274
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447275
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447305
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447306
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447308
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447309
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447310
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447311
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447312
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447313
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447314
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447315
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447316
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447317
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447324
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447328
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447330
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447333
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447335
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447337
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447340
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447341
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447342
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447343
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447346
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447348
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447352
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447353
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447354
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447355
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447356
Best Regards,
BrowserStack Support Team
|
Hi Browserstack,
Thanks for reaching out.
Kindly allow us some time to check this and get back to you with a response.
Your ticket ID: #1447359
Best Regards,
BrowserStack Support Team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing files using paths constructed from user-controlled data can allow an attacker to access unexpected resources. This can result in sensitive information being revealed or deleted, or an attacker being able to influence behavior by modifying unexpected files.
Fix this issue should validate any user-provided path before passing it to filesystem APIs. The best way to do this is to ensure that the final path, after normalization (using
path.resolve
and, optionally,fs.realpathSync
), remains within the intended safe root directory. For the_patch
handler, this is__dirname
; for the default handler, it'sprocess.cwd()
. You should update both handlers to resolve and check their paths, and modifyhandleFile
to accept only validated file paths.Concrete steps:
_patch
and_default
handlers, after joining the root + user path, normalize the path and check that it starts with the intended root (usingpath.resolve
andfs.realpathSync
if available).handleFile
if the path is safe.No new methods or imports are needed, as both
path
andfs
are already present.Edits required:
_patch
and_default
handlers (lines ~524-535), update file path resolution, add containment check, error out if the check fails.References
npm:sanitize-filename