Fix deleted temporary variables and update gradle and gradle dependencies #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add eclipse annotations as compileOnly for non-eclipse IDEs. - Update Skript dependency. - Switch SpigotMC dependency to PaperMC as it requires no local BuildTools dependencies for using org.bukkit.Bukkit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Gradle and dependencies to up-to-date ones. I added eclipse annotations to dependencies to achieve compatibility with IntelliJ (which is the IDE I was using). There was an abstract class implementation which prevented me from compiling, I modified that. Other than that, this fixes temporary variables that are deleted during async request. I took the reference from local variables using reflection and saved it inside another hashmap, deleted it after request clears out. It is dirty, yet working. I don't know if there are any memory leaks, but there shouldn't be any I guess.
Sorry for the third mention, here is the issue related to this: #11