drop artifactory from generate-react-native-fixture script #2476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (const pkg of packages) { | ||
| // move the tarball to the fixture directory | ||
| const tarballName = `bugsnag-${pkg}-*.tgz` | ||
| const tarballFiles = fs.readdirSync(packagesDir).filter(file => file.match(new RegExp(tarballName.replace('*', '.*')))) |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 months ago
To fix the issue, we need to ensure that all occurrences of * in tarballName are replaced with .*. This can be achieved by using a regular expression with the global flag (g) in the replace method. This change ensures that the resulting regular expression correctly matches files even if tarballName contains multiple * characters.
The specific change involves replacing tarballName.replace('*', '.*') with tarballName.replace(/\*/g, '.*'). This uses a regular expression to match all * characters globally and replaces them with .*.
Suggested changeset
1
scripts/generate-react-native-fixture.js
| @@ -117,3 +117,3 @@ | ||
| const tarballName = `bugsnag-${pkg}-*.tgz` | ||
| const tarballFiles = fs.readdirSync(packagesDir).filter(file => file.match(new RegExp(tarballName.replace('*', '.*')))) | ||
| const tarballFiles = fs.readdirSync(packagesDir).filter(file => file.match(new RegExp(tarballName.replace(/\*/g, '.*')))) | ||
| if (tarballFiles.length === 0) { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Design
Changeset
Testing