Skip to content

Fix for SS4 compatibility #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for SS4 compatibility #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d9a727
Fix for SS4 compatibility
jinjie Jun 6, 2022
36d61b9
Banners Link back in action for SS4
jinjie Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/BannerImage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

use SilverStripe\ORM\DataObject;
use SilverStripe\Security\Permission;
use Image;
use SilverStripe\Assets\Image;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Forms\TreeDropdownField;
use Page;

class BannerImage extends DataObject
Expand All @@ -15,19 +17,19 @@ class BannerImage extends DataObject
private static $db = array(
'Title' => 'Varchar(255)',
'SubTitle' => 'Varchar(255)',
// 'Link' => 'LinkField', // TODO: support linking banners in ss4
'Sort' => 'Int'
);

private static $has_one = array(
'Image' => Image::class,
'Parent' => Page::class
'Parent' => Page::class,
'Link' => SiteTree::class,
);

private static $summary_fields = array(
'Image.CMSThumbnail' => 'Image',
'CMSTitle' => 'Title',
// 'Link' => 'Link'
'Link.Title' => 'Link'
);

private static $default_sort = "\"Sort\" ASC, \"ID\" ASC";
Expand All @@ -40,6 +42,16 @@ public function getCMSFields()
$fields->insertBefore($image, 'Title');
$fields->removeByName('ParentID');
$fields->removeByName('Sort');

$fields->replaceField(
'LinkID',
TreeDropdownField::create(
'LinkID',
'Link',
SiteTree::class
)
);

return $fields;
}

Expand Down
4 changes: 2 additions & 2 deletions src/BannersExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Burnbright\SilverstripeBanner;

use BannerImage;
use Burnbright\SilverstripeBanner\BannerImage;
use SilverStripe\Forms\FieldList;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Forms\GridField\GridField;
Expand All @@ -12,7 +12,7 @@
class BannersExtension extends DataExtension
{

public static $has_many = array(
private static $has_many = array(
'Banners' => BannerImage::class
);

Expand Down