SS4/PHP compatibility tweaks #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torNotFoundException error 'ExternalURL does not exist'
…ods should be compatible with parent methods in php'
…rectory rather than project root
|
Apologies, have added the vendor-plugin dependency (required with the package type change to silverstripe-vendormodule). Have also removed PHP 5.5 from the .travis.yml, given that SS4 only supports >=5.6/7.x. |
|
Hey! #17 has implemented the Travis and |
|
@dizzystuff I've rebased here, feel free to use it or I can open a new PR if you like. |
|
Would it be possible to have these merged? 🙂 |
Merged
|
I've opened a PR with the rebased changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating composer package type from 'silverstripe-module' to 'silverstripe-vendormodule' so that the package is installed to /vendor directory rather than project root.
Updating ExternalURLField::setValue method arguments, to resolve php E_STRICT notice
declaration of methods should be compatible with parent methods in php.Applying injection pattern per silverstripe-framework's DBField classes, to resolve
Uncaught SilverStripe\Core\Injector\InjectorNotFoundException: ReflectionException: Class ExternalURL does not exist in /framework/src/Core/Injector/InjectionCreator.php:17