feat(rumqttc): Do concurrent network connections (#939) #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of routing issues, the individual socket connections will take ~4.5 minutes depending on OS level socket syn retransmit settings, which means that if there is a connection timeout that is shorter than that, connection will never be established even if other IP's resolve and route properly. This implements concurrent connection attempts with a staggerd delay between attempts. I have chosen not to implement a full version of RFC8305 (Happy Eyeballs) here, as that is a much more invasive change. Signed-off-by: D.S. Ljungmark <[email protected]> Issue: bytebeamio#939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of routing issues, the individual socket connections will take ~4.5 minutes depending on OS level socket syn retransmit settings, which means that if there is a connection timeout that is shorter than that, connection will never be established even if other IP's resolve and route properly.
This implements concurrent connection attempts with a staggerd delay between attempts. I have chosen not to implement a full version of RFC8305 (Happy Eyeballs) here, as that is a much more invasive change.
Issue: #939
Type of change
Bug fix
Checklist:
cargo fmtCHANGELOG.mdif it's relevant to the users of the library. If it's not relevant mention why.