Skip to content

fix: semver bug #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: semver bug #376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a71d5c
fix: bug that incorrectly generates WIT worlds with words that start …
asteurer Aug 9, 2025
2b382e6
fix: bug that incorrectly generates WIT worlds with words that start …
asteurer Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion wit/bindgen/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2436,7 +2436,34 @@ func (g *generator) newPackage(w *wit.World, i *wit.Interface, name string) (*ge
return pkg, nil
}

var replacer = strings.NewReplacer("/", "-", ":", "-", "@", "-v", ".", "", "%", "")
var replacer = strings.NewReplacer(
"/", "-",
":", "-",
"@", "-v",
".", "",
"%", "",
// The below replacements will ensure that worlds generated from the package name
// follow WIT identifier rules disallowing words to begin with a digit
// and still allow package names to use semver. For example, the package
// `wasi:io/[email protected]` will be used to generate the following world:
//
// world wasi-io-WORLD-imports-v020-rc-x2023-x11-x10`{
// ...
///}
///
// See https://component-model.bytecodealliance.org/design/wit.html#identifiers
// and https://github.com/WebAssembly/component-model/blob/main/design/mvp/WIT.md#package-names
"-0", "-x0",
"-1", "-x1",
"-2", "-x2",
"-3", "-x3",
"-4", "-x4",
"-5", "-x5",
"-6", "-x6",
"-7", "-x7",
"-8", "-x8",
"-9", "-x9",
)

// componentEmbed runs generated WIT through wasm-tools to generate a wasm file with a component-type custom section.
func (g *generator) componentEmbed(witData string) ([]byte, error) {
Expand Down
Loading