Merge dev/zephyr_file_socket into main #4347
Open
+9,956
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lum1n0us , We have got in touch with Stephen Berard and learned from him that this branch is not the latest one he is using. After mentioning the merge to main, he also expressed his willingness to submit the PR. However, he needs to fix some bugs, so he might submit the latest modifications he has developed this week. I wonder if we could also keep an eye on his latest progress, and I could also carry out development on his branch. Also, regarding the CI/CD deployment in Zephyr mentioned today. We may not have relevant experience, but we will look for relevant solutions in other teams within the company. |
lum1n0us
added
the
new feature
lum1n0us
requested review from
loganek,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
no1wudi
approved these changes
Aug 12, 2025
) To address #3311. This work also implements the WASI support on Zephyr. Note that some comments haven't been addressed and will be fixed in the further patches.
Fixed issues in os_renameat and added os_is_* methods for stdin/stdout/stderr. ps. #3311. Signed-off-by: Stephen Berard <[email protected]>
…ck_recv_from() (#4391) `src_addr` will be filled upon return. Before the call, its content is unpredictable.
* Added os_is_* methods for stdin/stdout/stderr. Fixed issues in os_renameat * Zephyr platform fixes for WASI sockets Addressed numerous of build warnings on Zephyr * Updated `os_writev` to use `fwrite` for STDOUT/STDERR * Temporarily reverted change to `writev` to work around an issue. * Fixes: fstat, fstatat, and unlink * Add initial support for directories in os_openat. Partial implementation — just avoids a hard fault. Signed-off-by: Stephen Berard <[email protected]> Co-authored-by: Dan Kouba <[email protected]>
lum1n0us
force-pushed
the
dev/zephyr_file_socket
branch
from
3e820aa to
87732f2
Compare
* Directory support WIP. readdir works but I think we have a memory leak somewhere * Fix: always use standard stream fds. Fix unlinkat and renameat. fd 0, 1, and 2 will always be supplied for standard streams. Unlinkat and renameat work exclusively based on supplied paths. * Fix: use macro for free() * Added a temporary workaround for issue identified in PR#4377 * Fixed reference to file descriptor and cleaned up dead/commented code. Signed-off-by: Stephen Berard <[email protected]> Co-authored-by: Dan Kouba <[email protected]>
lum1n0us
force-pushed
the
dev/zephyr_file_socket
branch
from
87732f2 to
6cfc08e
Compare
TianlongLiang
approved these changes
Aug 25, 2025
yamt
reviewed
Aug 25, 2025
| # Copyright (C) 2024 Grenoble INP - ESISAR. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| # Python script to convert wasm file to byte array in a .h file |
There was a problem hiding this comment.
why don't you use test-tools/binarydump-tool?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.