Prioritize inline worlds, not external ones
#1358
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple `path`s are used the `generate!` macro will fail if they all contain a `world` and no world is otherwise specified. This then additionally affected when using `inline` plus loading auxiliary WIT from a `paths` directory (either explicitly or the default `wit`). This commit switches the logic to prioritizing worlds in the `inline` block because if that's being specified it's pretty likely the exact one that wants to be used.
pchickey
approved these changes
Aug 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
cc @bytecodealliance/dotnet-core do y'all know what's going on with the C# failures in this PR? I've retried a few times over a day or so and so it doesn't seem spurious |
|
Looks all green, where can I see the failures? |
|
This is failing when going through the merge queue, so you'll need to hit "View details" buttons on the right. An example is https://github.com/bytecodealliance/wit-bindgen/actions/runs/17137088638/job/48615613853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple
paths are used thegenerate!macro will fail if they all contain aworldand no world is otherwise specified. This then additionally affected when usinginlineplus loading auxiliary WIT from apathsdirectory (either explicitly or the defaultwit). This commit switches the logic to prioritizing worlds in theinlineblock because if that's being specified it's pretty likely the exact one that wants to be used.