resolve duplicate key warnings in SideList and remove unused dispatch parameters #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters This commit resolves duplicate key warnings in the SideList component and removes unused dispatch parameters. In the SideList component, the hard-coded key "menu-items" has been replaced with a unique key generated from the array index, ensuring that each rendered item has a distinct identifier, which eliminates React’s duplicate key warnings. Additionally, unused dispatch parameters in orgActions.js and tutorialPageActions.js were removed, addressing ESLint no-unused-vars errors. These fixes enhance code quality and prevent potential issues during pre-commit checks.Migrated the project's ESLint configuration from .eslintrc.js to a new eslint.config.js file at the root. The new configuration uses the flat config format required by ESLint v9, specifying languageOptions, plugins, rules, and settings appropriately. This change resolves the error indicating that ESLint couldn't find an eslint.config file, ensuring compatibility with the latest ESLint version.
… parameters This commit resolves duplicate key warnings in the SideList component and removes unused dispatch parameters. In the SideList component, the hard-coded key "menu-items" has been replaced with a unique key generated from the array index, ensuring that each rendered item has a distinct identifier, which eliminates React’s duplicate key warnings. Additionally, unused dispatch parameters in orgActions.js and tutorialPageActions.js were removed, addressing ESLint no-unused-vars errors. These fixes enhance code quality and prevent potential issues during pre-commit checks.Renamed eslint.config.js to eslint.config.cjs to ensure the configuration is treated as CommonJS.Removed the "root" key from eslint.config.cjs, as flat configs are always treated as the root.
|
Added some comments. |
|
Added some comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit addresses multiple issues in the project. In the SideList component, duplicate key warnings were fixed by replacing a hard-coded key with a unique key derived from the array index, ensuring each list item is uniquely identified by React. Unused dispatch parameters were removed from orgActions.js (line 431) and tutorialPageActions.js (line 280), which resolves ESLint no-unused-vars errors. Additionally, the ESLint configuration was migrated from the legacy .eslintrc format to the new flat config system required by ESLint v9. This involved creating an
eslint.config.cjsfile, converting it to use CommonJS syntax (replacing ES module syntax), and removing the unsupported "root" key. These changes improve code quality, resolve build and linting errors, and ensure compatibility with the latest ESLint standards.Related Issue
None
Motivation and Context
The changes were necessary to fix linting and configuration errors that were preventing successful pre-commit checks and code builds. Resolving duplicate key warnings in React and unused variable errors not only cleans up the code but also enhances maintainability. Migrating to the new ESLint flat configuration format ensures future compatibility and adherence to modern development practices.
How Has This Been Tested?
npm run lintto verify that all ESLint errors are resolved.Screenshots or GIF (In case of UI changes):
N/A
Types of changes
Checklist: