-
Notifications
You must be signed in to change notification settings - Fork 124
feat: Use fetcher in workflow history #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Assem-Uber
merged 14 commits into
cadence-workflow:master
from
Assem-Uber:feature/15952/use-fetcher-in-workflow-history-page
Nov 10, 2025
Merged
feat: Use fetcher in workflow history #1064
Assem-Uber
merged 14 commits into
cadence-workflow:master
from
Assem-Uber:feature/15952/use-fetcher-in-workflow-history-page
Nov 10, 2025
+86
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
macrotim
approved these changes
Nov 5, 2025
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Signed-off-by: Assem Hafez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use new fetcher hook in the history page. This replaces old logic of
useKeepLoadingEventshook which depends on the render cycle completion to start fetching the next page. The new hook allows throttle query data updates and render once after few requested pages.Changes
useSuspenseInfiniteQuerywith the new fetcher hookuseKeepLoadingEventswith usage for start/stop methods from fetcheruseKeepLoadingEventsas it is no longer used.Recording
Using custom buttons to validate start/stop/error of the fetcher on the history page.
The start/pause/error buttons are for testing purposes
Tested scenarios:
Screen.Recording.2025-11-03.at.11.07.09.mov
Risks
If fetcher is problematic, loading more pages may not happen. Ending up with a partially fetched history.