UI updates #2368
Merged
UI updates #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuxpizza what's the state of this? |
This change: - Adds support for custom themes - Updates theme retrieval logic to ensure the right theme is used based on user preferences(especially for custom themes).
…, black theme now ready for tests
- Enhanced theme selection UI in display settings to support accent color choices. - Updated theme handling logic to accommodate new accent color variants.
…some color changes
…ggleKnob custom colors
OmarHatem28
reviewed
Oct 9, 2025
lib/src/screens/dashboard/desktop_widgets/desktop_wallet_selection_dropdown.dart
Outdated
Show resolved
Hide resolved
Comment on lines
133
to
138
| double getHeight(MaterialThemeBase theme, bool hasAccentColors) { | ||
| if (theme is BlackTheme && hasAccentColors) return 356; | ||
|
|
||
| if (hasAccentColors) return 306; | ||
|
|
||
| return 236; |
There was a problem hiding this comment.
not sure if fixed numbers would be good and work on large screens as well
…tion_dropdown.dart Co-authored-by: Omar Hatem <[email protected]>
…sier retrieval of current theme and custom colors
…t and adjust across affected widgets
…ngsSwitcherCell, using ThemeX extension for theme access
…t on SettingsSwitcherCell and StandardxSwitcher, using ThemeX extension for theme access
…itching to theme extension
…idgets, switching to theme extension
…nstead of constructor access
…on-based theme usage
OmarHatem28
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.