LCW-1128-Add-support-for-Trezor #2565
Open
+986
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarHatem28
reviewed
Oct 10, 2025
| final inputTx = BtcTransaction.fromRaw(hex.encode(inputTxRaw!)); | ||
| final inputOutputIndex = psbt.getInputOutputIndex(i); | ||
|
|
||
| final publicKeys = psbt.inputMaps[i].keys.where((e) => e.startsWith("06")); |
There was a problem hiding this comment.
what's 06? and also this part can use a little bit of code documentation
There was a problem hiding this comment.
06 is the psbt key for a public key. So here we are selecting all public keys of that input
| linkViewModel: linkViewModel, | ||
| tradeMonitor: tradeMonitor, | ||
| nodeSwitchingService: nodeSwitchingService, | ||
| trezorConnect: getIt<TrezorConnect>(), |
There was a problem hiding this comment.
why keep the object live for every instance of the app, just to check if a deep link contains a static string callbackBackUri
just check that static string in root.dart and if it indeed is targeted for Trezor, then initialize this
There was a problem hiding this comment.
I didn't want to have a getIt call inside root.dart
# Conflicts: # lib/src/screens/connect_device/select_device_manufacturer_page.dart
…transaction signing logic, and improve modularity in hardware wallet services
…and cleanup Trezor chainId handling logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add trezor support for BTC, LTC, ETH, POL using Trezor Connect
Pull Request - Checklist