Skip to content

Conversation

borisyankov
Copy link

This should work, but currently 'dts' generation fails for all remotes.

Exception thrown inside dts-plugin.

We should use this a preproduction, until fixed.

This should work, but currently 'dts' generation fails for all remotes.

Exception thrown inside `dts-plugin`.

We should use this a preproduction, until fixed.
@thymikee
Copy link
Member

thymikee commented Feb 1, 2025

How is HMR performance affected? I recall turning dts on made recompilation super slow on rspack 1.0 and 1.1

@borisyankov
Copy link
Author

@jbroma said the perf issues were fixed on their side, and from my testing type generation looks fast enough.

The blocker is that the full process does not finish - @mf-types.zip is not created, though d.ts files are.

@jbroma
Copy link
Member

jbroma commented Feb 1, 2025

How is HMR performance affected? I recall turning dts on made recompilation super slow on rspack 1.0 and 1.1

performance impact should be fixed already 👍

@jbroma said the perf issues were fixed on their side, and from my testing type generation looks fast enough.

The blocker is that the full process does not finish - @mf-types.zip is not created, though d.ts files are.

since problems like this are still there, and are not addressed we should hold off with enabling DTS here imo

@borisyankov
Copy link
Author

Oh, yeah. The error is definitely blocking for merging this PR.

But it might serve as a reproduction when reporting the issue to MF's guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants