-
Notifications
You must be signed in to change notification settings - Fork 65
feat: drop SDWebImage, implement svg decoder #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: a862617 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d4b129a
to
e513fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR drops the SDWebImage dependency and implements a custom SVG decoder to simplify the installation process and reduce build issues. The changes significantly streamline the setup by removing complex iOS configuration requirements previously needed for SDWebImage and SDWebImageSVGCoder.
Key changes:
- Replaces SDWebImage with a native SVG decoder using CoreSVG framework
- Removes complex iOS build configuration requirements from documentation
- Integrates the custom SVG decoder with React Native's TurboModule system
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/react-native-bottom-tabs/src/NativeSVGDecoder.ts | Adds TurboModule interface for the new SVG decoder |
packages/react-native-bottom-tabs/react-native-bottom-tabs.podspec | Removes SDWebImage dependencies and updates codegen configuration |
packages/react-native-bottom-tabs/ios/SVG/*.{h,mm} | Implements custom SVG decoder using CoreSVG framework |
packages/react-native-bottom-tabs/ios/TabViewProvider.swift | Replaces SDWebImage with React Native's image loader |
packages/react-native-bottom-tabs/ios/*ComponentView.mm | Updates component views to use image loader parameter |
docs/docs/docs/getting-started/quick-start.mdx | Simplifies installation instructions by removing iOS configuration steps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/react-native-bottom-tabs/ios/Fabric/RCTTabViewComponentView.mm
Outdated
Show resolved
Hide resolved
92a1cab
to
b158716
Compare
b158716
to
fdde3ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4ffb3e3
to
2ed2ab3
Compare
2ed2ab3
to
a862617
Compare
PR Description
This PR drops SDWebImage, implements SVG Decoder.
This makes installation instructions MUUUUUCH simpler. Hopefully people will no longer run into build issues after this.