Skip to content

Conversation

okwasniewski
Copy link
Collaborator

PR Description

This PR drops SDWebImage, implements SVG Decoder.

This makes installation instructions MUUUUUCH simpler. Hopefully people will no longer run into build issues after this.

Copy link

changeset-bot bot commented Sep 14, 2025

🦋 Changeset detected

Latest commit: a862617

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-native-bottom-tabs Minor
@bottom-tabs/expo-template Patch
@bottom-tabs/react-navigation Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okwasniewski okwasniewski changed the title feat: drop sdwebimage, implement svg decoder feat: drop SDWebImage, implement svg decoder Sep 14, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR drops the SDWebImage dependency and implements a custom SVG decoder to simplify the installation process and reduce build issues. The changes significantly streamline the setup by removing complex iOS configuration requirements previously needed for SDWebImage and SDWebImageSVGCoder.

Key changes:

  • Replaces SDWebImage with a native SVG decoder using CoreSVG framework
  • Removes complex iOS build configuration requirements from documentation
  • Integrates the custom SVG decoder with React Native's TurboModule system

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/react-native-bottom-tabs/src/NativeSVGDecoder.ts Adds TurboModule interface for the new SVG decoder
packages/react-native-bottom-tabs/react-native-bottom-tabs.podspec Removes SDWebImage dependencies and updates codegen configuration
packages/react-native-bottom-tabs/ios/SVG/*.{h,mm} Implements custom SVG decoder using CoreSVG framework
packages/react-native-bottom-tabs/ios/TabViewProvider.swift Replaces SDWebImage with React Native's image loader
packages/react-native-bottom-tabs/ios/*ComponentView.mm Updates component views to use image loader parameter
docs/docs/docs/getting-started/quick-start.mdx Simplifies installation instructions by removing iOS configuration steps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@okwasniewski okwasniewski force-pushed the feat/drop-sdwebimage branch 2 times, most recently from 92a1cab to b158716 Compare September 14, 2025 07:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@okwasniewski okwasniewski force-pushed the feat/drop-sdwebimage branch 4 times, most recently from 4ffb3e3 to 2ed2ab3 Compare September 15, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant