Skip to content

Use $() instead of backticks #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

Use $() instead of backticks #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
172910d
Update build.gradle to use $() instead of backticks
kraenhansen Sep 16, 2025
63ecf84
Update ANDROID docs
kraenhansen Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/ANDROID.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ This will print a path which needs to be stored in `REACT_NATIVE_OVERRIDE_HERMES
This can be combined into a single line:

```
export REACT_NATIVE_OVERRIDE_HERMES_DIR=`npx react-native-node-api vendor-hermes --silent`
export REACT_NATIVE_OVERRIDE_HERMES_DIR=$(npx react-native-node-api vendor-hermes --silent)
```

## Cleaning your React Native build folders
Expand Down
2 changes: 1 addition & 1 deletion packages/host/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ task checkHermesOverride {
"React Native Node-API needs a custom version of Hermes with Node-API enabled.",
"Run the following in your terminal, to clone Hermes and instruct React Native to use it:",
"",
"export REACT_NATIVE_OVERRIDE_HERMES_DIR=`npx react-native-node-api vendor-hermes --silent --force`",
"export REACT_NATIVE_OVERRIDE_HERMES_DIR=$(npx react-native-node-api vendor-hermes --silent --force)",
"",
"And follow this guide to build React Native from source:",
"https://reactnative.dev/contributing/how-to-build-from-source#update-your-project-to-build-from-source"
Expand Down
Loading