Skip to content

Conversation

@wdichler
Copy link

Bugfix: Get next token, in unary filters. We found the end of the object. But we forgot to forward the parser to the next token.

Bugfix: Get next token, in unary filters. We found the end of the object. But we forgot to forward the parser to the next token.
@candoumbe
Copy link
Owner

candoumbe commented Dec 9, 2024

Hi @wdichler !!!
Thank you for your contribution

May I ask for unit tests to validate your pull request ?
I think it would also be good to describe the problem you faced in a dedicated issue. you encountered.

@candoumbe candoumbe self-assigned this Dec 11, 2024
@candoumbe candoumbe self-requested a review December 11, 2024 08:14
@candoumbe candoumbe removed their assignment Dec 11, 2024
Copy link
Owner

@candoumbe candoumbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submiiting this PR !

Please could you add a test + an issue to describe what this PR will

@wdichler
Copy link
Author

I need some time, i will deliver in the end of the week.

@candoumbe candoumbe enabled auto-merge (rebase) December 23, 2024 20:05
@candoumbe candoumbe disabled auto-merge December 23, 2024 20:05
@candoumbe candoumbe enabled auto-merge (rebase) December 24, 2024 10:46
@candoumbe candoumbe disabled auto-merge December 24, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants