Skip to content

Reenable Dropbox integration #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reenable Dropbox integration #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/webamp/demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@
}
}, 500)
</script>
<!-- https://github.com/captbaritone/webamp/issues/750
<script type="text/javascript" src="https://www.dropbox.com/static/api/2/dropins.js" id="dropboxjs" data-app-key="7py29249dpeddu8" async></script>
-->
<!-- Scripts get injected by html-webpack-plugin -->
</body>

Expand Down
4 changes: 0 additions & 4 deletions packages/webamp/demo/js/dropboxFilePicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ function genAudioFileUrlsFromDropbox(): Promise<DropboxFile[]> {
const dropboxFilePicker: FilePicker = {
contextMenuName: "Dropbox...",
filePicker: async () => {
alert(
`Dropbox integration is currently disabled. See https://github.com/captbaritone/webamp/issues/750 for more information.`
);
// https://github.com/captbaritone/webamp/issues/750
const files = await genAudioFileUrlsFromDropbox();
return files.map((file) => ({
url: file.link,
Expand Down