fix(notification): align toast notification details spacing with design spec #20605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maradwan26
requested review from
a team,
kennylam and
sunny-babbar
and removed request for
a team
sunny-babbar
approved these changes
Sep 26, 2025
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20605 +/- ##
==========================================
+ Coverage 91.39% 92.13% +0.73%
==========================================
Files 485 484 -1
Lines 31370 32729 +1359
Branches 5430 5574 +144
==========================================
+ Hits 28670 30154 +1484
+ Misses 2547 2429 -118
+ Partials 153 146 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
tay1orjones
approved these changes
Sep 30, 2025
|
@kennylam is moving the position of a slot in the dom a disruptive (or breaking?) change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20570
Fixed a bug with the toast notification spacing in web components to match the design spec.
Changelog
Removed
${prefix}--${type}-notification__detailsclass being applied twiceTesting / Reviewing
Notifications/Toast/Defaultin WC Deploy PreviewPR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)