- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2k
fix: add role="group" to TableToolbar for proper accessibility #20637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| All contributors have signed the DCO. | 
| ✅ Deploy Preview for v11-carbon-web-components ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| ✅ Deploy Preview for carbon-elements ready!
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
| ✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables 
 To edit notification comments on pull requests, go to your Netlify project configuration. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main   #20637      +/-   ##
==========================================
+ Coverage   91.39%   92.26%   +0.86%     
==========================================
  Files         485      499      +14     
  Lines       31370    34853    +3483     
  Branches     5430     5647     +217     
==========================================
+ Hits        28670    32156    +3486     
- Misses       2547     2549       +2     
+ Partials      153      148       -5     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
e710f67
    
Closes #20623
Short Description: Fixed TableToolbar accessibility issue by adding explicit
role="group"to prevent inappropriate region landmark behavior.Changelog
Changed
role="group"attribute to TableToolbar<section>element to override implicit region roleAccessibility