Skip to content

Conversation

@naaa760
Copy link
Contributor

@naaa760 naaa760 commented Oct 2, 2025

Closes #20623

Short Description: Fixed TableToolbar accessibility issue by adding explicit role="group" to prevent inappropriate region landmark behavior.

Changelog

Changed

  • Added role="group" attribute to TableToolbar <section> element to override implicit region role
  • Updated test snapshot to reflect new HTML structure

Accessibility

  • Resolved a11y violation where TableToolbar created inappropriate landmark region for screen readers

@naaa760 naaa760 requested a review from a team as a code owner October 2, 2025 01:29
@naaa760 naaa760 requested review from kennylam and maradwan26 October 2, 2025 01:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 8e23093
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/68f0eafd13d0c700088ba5e5
😎 Deploy Preview https://deploy-preview-20637--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8e23093
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/68f0eafda23d610008292667
😎 Deploy Preview https://deploy-preview-20637--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e23093
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68f0eafd6a713200081e7dd5
😎 Deploy Preview https://deploy-preview-20637--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@maradwan26 maradwan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.26%. Comparing base (30b4f87) to head (8e23093).
⚠️ Report is 307 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20637      +/-   ##
==========================================
+ Coverage   91.39%   92.26%   +0.86%     
==========================================
  Files         485      499      +14     
  Lines       31370    34853    +3483     
  Branches     5430     5647     +217     
==========================================
+ Hits        28670    32156    +3486     
- Misses       2547     2549       +2     
+ Partials      153      148       -5     
Flag Coverage Δ
main-packages 85.41% <ø> (+0.48%) ⬆️
web-components 97.10% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kennylam kennylam added this pull request to the merge queue Oct 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2025
@maradwan26 maradwan26 added this pull request to the merge queue Oct 16, 2025
Merged via the queue into carbon-design-system:main with commit e710f67 Oct 16, 2025
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y]: TableToolbar: inappropriate region role

3 participants